RFR: 8317340: Windows builds are not reproducible if MS VS compiler install path differs

[Andrew Leonard]

On Mon, 2 Oct 2023 14:13:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>>> What effect will this have on debugging?
>> 
>> Hi @erikj79 
>> So this is the same as we pathmap the openjdk workspace source just above, in that we only do it when ALLOW_ABSOLUTE_PATHS_IN_OUTPUT is "false", which is for release builds.
>> For "debug" builds it is "true" and no pathmap'ing occurs, see: https://github.com/openjdk/jdk/blob/2637e8ddc4ffe102418139f501fc0be8e9c5317b/make/autoconf/jdk-options.m4#L696
>
>> > What effect will this have on debugging?
>> 
>> Hi @erikj79 So this is the same as we pathmap the openjdk workspace source just above, in that we only do it when ALLOW_ABSOLUTE_PATHS_IN_OUTPUT is "false", which is for release builds. For "debug" builds it is "true" and no pathmap'ing occurs, see:
> 
> Yes, I'm aware of that. I was just curious if you had tested and investigated the consequences of doing this when trying to debug a "release" build. I'm not against this change, but it would be good to understand any consequences.

@erikj79 I shall run a debug session on a release image and see what if anything it causes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16008#issuecomment-1743118298