RFR: 8317340: Windows builds are not reproducible if MS VS compiler install path differs

Erik Joelsson erikj at openjdk.org
Thu Oct 5 14:25:16 UTC 2023


On Mon, 2 Oct 2023 10:31:41 GMT, Andrew Leonard <aleonard at openjdk.org> wrote:

> When doing a reproducible Windows build on two different machines, that
> happen to have MS Visual Studio installed in different paths, the resulting
> builds are not identical. This is due to the System include paths, eg:
> 
> C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\vcruntime_new.h
> 
> appearing in the compiler obj as part of debug info.
> 
> This PR tests when doing a Windows no-Absolute paths allowed build, and then
> adds -pathmap:<VS_include_long_path\>=vsi entries to re-map those entries in
> the compiler object.
> The VS cl compiler generates these paths as standard Windows "long path" entries,
> and must be pathmap'd as such.

It looks like this change broke the build on WSL. The pathtool in WSL (wslpath) does not support the `-l` option.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16008#issuecomment-1748929567


More information about the build-dev mailing list