RFR: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name [v2]

[Erik Joelsson]

On Mon, 9 Oct 2023 09:03:08 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

>> make/CreateJmods.gmk line 83:
>> 
>>> 81: ifneq ($(CMDS_DIR), )
>>> 82:   DEPS += $(call FindFiles, $(CMDS_DIR))
>>> 83:   ifeq ($(call isTargetOs, windows)+$(SHIP_DEBUG_SYMBOLS), true+public)
>> 
>> Suggestion:
>> 
>>   ifeq ($(call isCompiler, microsoft)+$(SHIP_DEBUG_SYMBOLS), true+public)
>> 
>> 
>> stripped pdbs (and pdbs in general) are only ever used with the VS toolchain
>
> I understand the point of this change, but it is not directly related to the issue addressed here (i.e. this condition wasn't introduced in this PR.).
> Should it be included in the PR anyway?

I agree with @fthevenet, such a change should be separate from this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16039#discussion_r1350267723