RFR: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name [v3]

[Frederic Thevenet]

On Tue, 10 Oct 2023 16:17:17 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> In our internal build-and-test system, we provide SYMBOLS_IMAGE_DIR as an env variable when invoking test-prebuilt, and the test passes in this setup. From your description it seems our GHA are supposed to be setup in the same way, but maybe there is a bug in there somewhere.

If it isn't too much of a bother, could you please verify that the path you pass via SYMBOLS_IMAGE_DIR is indeed listed in the symbol engine search path in the resulting hs_err produced as part of the test?
I have been doing some testing locally (without GHA) and I'm seeing weird things in the symbol engine logs in hs_err, like the path passed to SYMBOLS_IMAGE_DIR not being converted to Windows path, while JDK_IMAGE_DIR is, e.g.:

Command line:
`make test-prebuilt BOOT_JDK=/cygdrive/c/java-21-openjdk-21.0.0.0.35-7.win.jdk.x86_64/ JT_HOME=../../upstream/jtreg/build/images/jtreg JDK_IMAGE_DIR=build/prebuilt_images/jdk/ SYMBOLS_IMAGE_DIR=build/prebuilt_images/symbols/ TEST_IMAGE_DIR=build/prebuilt_images/test/ TEST="test/hotspot/jtreg/runtime/errorhandling/TestSymbolsInHsErrFile.java"`

hs_err:
`symbol engine: initialized successfully - sym options: 0x614 - pdb path: .; build/prebuilt_images/symbols//bin:build/prebuilt_images/symbols//bin/server;C:\openjdk\jdk\build\prebuilt_images\jdk\bin;C:\Windows\SYSTEM32;C:\Windows\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.19041.1110_none_60b5254171f9507e;C:\\openjdk\jdk\build\prebuilt_images\jdk\bin\server`

Also please note that if pdb files are present in the folder that you pass via JDK_IMAGE_DIR, the symbol engine will likely pick them up from there even if the path set in SYMBOLS_IMAGE_DIR is empty or incorrect (and therefore the test will pass).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16039#issuecomment-1755817084