RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v7]

[Julian Waters]

On Tue, 10 Oct 2023 03:44:27 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> We should set the -permissive- flag for the Microsoft Visual C compiler, as was requested by the now backed out [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes the Visual C compiler much less accepting of ill formed code, which will improve code quality on Windows in the future.
>
> Julian Waters has updated the pull request incrementally with five additional commits since the last revision:
> 
>  - Revert sspi.cpp
>  - Revert NativeCreds.c
>  - Revert allocation.cpp
>  - Revert symbolengine.cpp
>  - Revert os_windows.cpp

> This got a bit messy. In hindsight it would probably have been better to leave this closed and open a new bug. But what's done is done, let's not mess around any more at this point.
> 
> If all other places where `permissive-` failed are fixed, then I think it is okay to include the flag in this PR. Otherwise, you cannot do that. As a general rule, changing compiler options is best done in a separate patch, to differentiate any potential bad effect from actual code changes. However, in this case, I don't think the flag will cause any differences in the generated code, only in what syntax the compiler accepts, so I guess it is fine.
> 
> /reviewers 2

Sorry I was busy with work on my end, I'm not planning to integrate -permissive- in this Pull Request, I must have missed it. I'll remove it soon

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-1760636258