RFR: 8318078: ADLC: pass ASSERT and PRODUCT flags [v2]

[Emanuel Peter]

On Fri, 13 Oct 2023 17:23:32 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add comments like Vladimir requested
>
> make/hotspot/gensrc/GensrcAdlc.gmk line 138:
> 
>> 136:   # Set ASSERT, NDEBUG and PRODUCT flags just like in JvmFlags.gmk
>> 137:   ifeq ($(DEBUG_LEVEL), release)
>> 138:     ADLCFLAGS += -DNDEBUG
> 
> May be you should also copy all comments from `JvmFlags.gmk` to avoid confusion because, for example, `NDEBUG` is not used directly in HotSpot code but it is needed "to disable uses of assert macro from <assert.h>."

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16178#discussion_r1360341172