RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v11]
David Holmes
dholmes at openjdk.org
Wed Oct 18 00:03:58 UTC 2023
On Tue, 17 Oct 2023 11:43:59 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> A bug in GCC causes shared libraries linked with -ffast-math to disable denormal arithmetic. This breaks Java's floating-point semantics.
>>
>> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522
>>
>> One solution is to save and restore the floating-point control word around System.loadLibrary(). This isn't perfect, because some shared library might load another shared library at runtime, but it's a lot better than what we do now.
>>
>> However, this fix is not complete. `dlopen()` is called from many places in the JDK. I guess the best thing to do is find and wrap them all. I'd like to hear people's opinions.
>
> Andrew Haley has updated the pull request incrementally with three additional commits since the last revision:
>
> - Review feedback
> - Merge branch 'JDK-8295159' of https://github.com/theRealAph/jdk into JDK-8295159
> - Remove change to RestoreMXCSROnJNICalls
Meta-question and apologies if this was covered before, but why is this logic being added to stubRoutines.cpp?
-------------
PR Review: https://git.openjdk.org/jdk/pull/10661#pullrequestreview-1683665056
More information about the build-dev
mailing list