RFR: 8295795: hsdis does not build with binutils 2.39+ [v5]

[Magnus Ihse Bursie]

On Fri, 29 Sep 2023 16:39:23 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi please consider.
>> 
>> This works with 2.30, 2.34, 2.38, 2.39, 2.40, 2.41 and current master head. (tested x64 and some RV)
>> 
>> There are 4 changes in binutils we work around.
>> - zstd compressed debug sections
>> - libsframe added
>> - init_disassemble_info() change
>> - libbfd.a is only present in .lib directory in newer binutils builds (older it is in both directories) (I think the issue is that we never do make install, thus have dependency on internal artifact placement)
>> 
>> Specific to RV, there is a bug in binutils causing the standard extensions not being added to disassembler if we pass in NULL.
>> 
>> This no way near perfect, but at least we can build hsdis with any contemporary binutils.
>> 
>> Todo better I think we need to build and install binutils to check the version and then use that version to figure out what options to use when re-building and re-installing binutils for hsdis.
>> 
>> I asked tool-chain people about our issues, they said, you can't do that. I.e. have source dependencies on many binutils versions.
>> 
>> As RV is new and have new instructions added to it frequently we really need to be able to build with bleeding-edge binutils. (capstone RV is not actively worked on, llvm have many more dependencies)
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor fixes

I still think we're talking past each other here.

I am talking about situation 3:
We have built and installed it locally with `make install`, and have removed the installation directory (or at least points the configure argument to the installed directory).

In this case, you will not have a .libs directory. 

I still don't see why it would be such big deal to check for the required files in both the directory directly, and then, if it is not found, check in a `.libs` directory? That's all I request, to increase the likelyhood that this works with many different kinds of setup.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15138#issuecomment-1768718738