RFR: 8318027: Support alternative name to jdk.internal.vm.compiler
Doug Simon
dnsimon at openjdk.org
Fri Oct 20 14:42:28 UTC 2023
On Fri, 20 Oct 2023 14:27:43 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> Why you replaced pair of copyright years with one year in module-info.Java files? Instead of updating last year only. Why also update 'since' there? Even if you changed location these files existed already.
The files may be renamed from git's point of view, but I would argue that these are new modules and so should have a new `@since` tag. Otherwise, someone seeing that `jdk.compiler.graal` existed `@since 9` may be a little surprised/confused if they look for it in a JDK 9 binary. Same thinking applies to the copyright dates. Happy to fix it if this is the wrong way to think about it.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16189#issuecomment-1772866757
More information about the build-dev
mailing list