RFR: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2 [v2]

Magnus Ihse Bursie ihse at openjdk.org
Wed Oct 25 12:06:31 UTC 2023


On Wed, 25 Oct 2023 08:46:52 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

>> This PR addresses OS detection not working properly when running test-prebuilt on MSYS2, which causes some Windows specific tests to misbehave or fail in Github Actions.
>
> Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use 'else ifeq' statement

This looks good. Thanks for fixing it!

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16343#pullrequestreview-1697124276


More information about the build-dev mailing list