RFR: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name [v3]

Frederic Thevenet fthevenet at openjdk.org
Wed Oct 25 13:27:38 UTC 2023


On Tue, 24 Oct 2023 22:21:00 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Frederic Thevenet has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added a test to verify that symbols are available
>
> You don't have to rebase, in fact, you should not rebase an open PR. Just merge from master, once the msys fix is in.
> 
> Your fix for JDK-8318669 was simple; just fix the "else ifeq" as Erik suggests, and you're good to go. So just delay pushing this a bit more -- you don't have to move it to Draft either. I think that is preferable, since it will keep the test with this PR, where it belongs.

@magicus So, just so that I get this strait, what you're suggesting is that now #16343 is integrated, I merge master _into_ my branch for the PR and push it, right?
(sorry for being a bit dense 😅)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16039#issuecomment-1779271236


More information about the build-dev mailing list