RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v11]

Andrew Haley aph at openjdk.org
Thu Oct 26 10:30:12 UTC 2023


On Thu, 19 Oct 2023 09:31:36 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 1853:
>> 
>>> 1851: 
>>> 1852: #ifndef IA32
>>> 1853:     // Quickly test to make sure denormals are correctly handled.
>> 
>> Nit: I recommend using "subnormal" rather than "denormal" for general terminology on this point. While "denormal" was used in the original IEEE 754 standard from 1985, subsequent iterations of the standard using "subnormal" The term "subnormal" has also been used for the last several editions of JLS and JVMS.
>
> I've long avoided "subnormal" because
> 
> subnormal in British English, adjective
> 3.  [old-fashioned, offensive] a person of low intelligence

All done. Good to go?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10661#discussion_r1372936648


More information about the build-dev mailing list