RFR: 8318834: s390x: Debug builds are missing debug helpers

Lutz Schmidt lucy at openjdk.org
Thu Oct 26 12:39:31 UTC 2023


On Wed, 25 Oct 2023 17:26:13 GMT, Andrew Haley <aph at openjdk.org> wrote:

> On s390x only, HotSpot is built by GCC with -ffunction-sections.
> This means that debug helpers such as ps() and pfl() are not available. These helpers are extremely useful in debugging, so it makes no sense to omit them from debug builds.

Looks good (and seems helpful).
Those link-time options had been introduced many years ago in an effort to trim binary sizes. The serviceability agent was never ported to s390x.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16365#pullrequestreview-1699521274


More information about the build-dev mailing list