RFR: 8318753: hsdis binutils may place libs in lib64

Daniel Jeliński djelinski at openjdk.org
Fri Oct 27 09:52:33 UTC 2023


On Thu, 26 Oct 2023 22:17:45 GMT, Claes Redestad <redestad at openjdk.org> wrote:

> The binutils build of libiberty is put in `$BINUTILS_INSTALL_DIR/lib64` on some Linux distributions (e.g. Fedora, Oracle Linux), `$BINUTILS_INSTALL_DIR/lib` on others (e.g. Ubuntu).
> 
> This PR suggest simply adding logic to look for `libiberty.a` in either place, favoring `.../lib` like now.  Alternative solutions like adding an explicit `--libdir=$BINUTILS_INSTALL_DIR/lib` in the binutils `configure` setup was tested, but this option was ignored by the libibrerty build on the binutils versions I've tried.

libiberty's `make install` always uses `gcc -print-multi-os-directory` to determine the target directory name. We can't change it.
The patch looks good to me.

-------------

Marked as reviewed by djelinski (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16387#pullrequestreview-1701406115


More information about the build-dev mailing list