RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v16]

[Andrew Haley]

On Thu, 26 Oct 2023 17:42:39 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove accidental include
>
> make/test/JtregNativeHotspot.gmk line 854:
> 
>> 852:   BUILD_HOTSPOT_JTREG_EXECUTABLES_LIBS_exeFPRegs := -ldl
>> 853:   BUILD_HOTSPOT_JTREG_LIBRARIES_LIBS_libAsyncGetCallTraceTest := -ldl
>> 854:   BUILD_HOTSPOT_JTREG_LIBRARIES_LDFLAGS_libfast-math := -ffast-math
> 
> Is the flag redundant by now? The test explicitly works with corresponding platform-specific registers.

it's belt-and braces (or belt-and-suspenders in American). This way, we can still do something useful for platforms not fully supported by mainline. I don't want to add ifdefs for every platform to the test.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/10661#discussion_r1374458024