RFR: JDK-8318961: increase javacserver connection timeout values and max retry attempts

Erik Joelsson erikj at openjdk.org
Fri Oct 27 20:30:31 UTC 2023


On Fri, 27 Oct 2023 10:43:58 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Increase javacserver connection timeout values and max retry attempts for better make stability on some slower machines.

make/langtools/tools/javacserver/client/Client.java line 57:

> 55:     private static final int CONNECTION_TIMEOUT = 4000;
> 56:     private static final int MAX_CONNECT_ATTEMPTS = 10;
> 57:     private static final int WAIT_BETWEEN_CONNECT_ATTEMPTS = 4000;

Not sure increasing the wait time is a good idea. If I'm reading this right, that means 8 seconds between each attempt if they are timing out. Will your problem still be alleviated if we keep the wait time at 2000?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16397#discussion_r1375015595


More information about the build-dev mailing list