RFR: JDK-8296240: Augment discussion of test tiers in doc/testing.md [v5]

Alan Bateman alanb at openjdk.org
Tue Oct 31 07:08:32 UTC 2023


On Tue, 31 Oct 2023 00:23:44 GMT, Joe Darcy <darcy at openjdk.org> wrote:

>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and regenerate the HTML file once the wording is agreed upon.
>
> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Initial check-in of updated HTML file.

doc/testing.md line 141:

> 139:   Roughly speaking, a failure of a test in this tier has the potential to
> 140:   indicate a problem that would affect many Java programs. Tests in `tier1` include
> 141:   tests of HotSpot, core libraries in the `java.base` module, and the `javac` compiler.

I think I'd tweak "core libraries in the java.base module" to say "core classes" or "core APIs", only because there isn't really any notion of a module containing libraries. If someone asks then they'll have to directed to the tier1 definition in test/jdk/TEST.groups as it's hard to come up with a one-line summary.

doc/testing.md line 147:

> 145:   manner.
> 146:   As a guideline, nearly all individual tests in `tier1` should complete in less than ten seconds
> 147:   when run on common configurations used for development. Long-running tests,

"should be complete" is okay, an alternative might be "are expected to complete" so better get across that it is aspirational.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16384#discussion_r1377131969
PR Review Comment: https://git.openjdk.org/jdk/pull/16384#discussion_r1377132736


More information about the build-dev mailing list