RFR: 8319121: hsdis binutils: speedup building from source
Robbin Ehn
rehn at openjdk.org
Tue Oct 31 13:09:40 UTC 2023
On Tue, 31 Oct 2023 12:53:56 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> > I think you are correct, I tested on some more machines.
> > On my vf2 dev board (4-core rv64) it do speed up sh configure, from 7:19 to 3:40. I see like 20 instances of cc1 instead 1, a bit to many.... :)
>
> Adding the `-j` flag without a number tells make to figure it out itself, which can lead to massive amounts of processes. Depending on the makefile, that can still work ok in many cases, but should probably not be applied by default.
>
> > I'll close PR and leave enhancement open! Thanks for having a look!
>
> Ok, I don't think moving `BPERF_SETUP_BUILD_JOBS` to before the libraries section is very controversial. Just include a comment explaining that it may be needed for more efficient library detection.
OK, thanks, I'll reiterate back to this when I got some more time, thanks again!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16421#issuecomment-1787184932
More information about the build-dev
mailing list