RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v34]

[Srinivas Vamsi Parasa]

On Mon, 11 Sep 2023 18:17:41 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix regression when intrinsics are disabled; enable insertion sort in intrinsic, change library name to libsimdsort
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4205:
> 
>> 4203: 
>> 4204:       snprintf(ebuf_, sizeof(ebuf_), "avx512_sort_double");
>> 4205:       StubRoutines::_arraysort_double = (address)os::dll_lookup(libsimdsort, ebuf_);
> 
> Hi @vamsi-parasa , If we align these C++ stub entry points with java intrinsic entry points which accept an element class argument, it will significantly cleanup the code referring to these stub entry points. We can pass an extra int type flag to stubs based on which C++ implementation can appropriately call type specific leaf level routines.

Hello Jatin, the suggested refactoring change is incorporated in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14227#discussion_r1323688986