RFR: 8315038: Capstone disassembler stops when it sees a bad instruction [v2]

Aleksey Shipilev shade at openjdk.org
Mon Sep 18 10:33:39 UTC 2023


On Mon, 18 Sep 2023 10:18:05 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> At present, the Capstone disassembler stops whenever it encounters an undefined instruction. We really need it not to do that, because we use undefined instructions in JIT-generated code for many things.
>> 
>> The fix is described here:
>>  https://www.capstone-engine.org/skipdata.html
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Comment text

Looks okay to me.

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15763#pullrequestreview-1630736095


More information about the build-dev mailing list