RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v36]

[Srinivas Vamsi Parasa]

On Sat, 16 Sep 2023 22:49:14 GMT, iaroslavski <duke at openjdk.org> wrote:

>> Hello Paul,
>> 
>> As suggested, the functional interfaces were moved next to the associated methods and also added a `@ForceInline` for `arraySort` in the latest commit.
>> 
>>> I recommend embedding the functional interfaces next to the associated methods, rather than as auxiliary classes, and also adding `@ForceInline` on `arraySort`.
>> 
>> Thanks,
>> Vamsi
>
> Hi @vamsi-parasa 
> 
> Why do we need ``if (indexPivot1 != indexPivot2) throw new IllegalArgumentException()``?
> If you implement logic correctly, you will never throw the exception.
> It is not business case, when exception makes sence.
> Therefore, I suggest removing this check.

Hello Vladimir (@iaroslavski),

Thanks for the suggestion. True, the exception check is not needed and removed in the latest commit pushed.

> Why do we need `if (indexPivot1 != indexPivot2) throw new IllegalArgumentException()`? If you implement logic correctly, you will never throw the exception. It is not business case, when exception makes sence. Therefore, I suggest removing this check.

Thanks,
Vamsi

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14227#issuecomment-1724187218