RFR: 8316433: net.dll should delay load winhttp.dll
Alan Bateman
alanb at openjdk.org
Tue Sep 19 06:43:40 UTC 2023
On Mon, 18 Sep 2023 17:30:25 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> WinHTTP functions are only used when an application:
> - uses DefaultProxySelector to resolve proxies, and
> - is run with -Djava.net.useSystemProxies=true
>
> In all other cases, loading winhttp.dll is a waste of resources.
>
> Verified that:
> - existing tier1 and tier2 tests still pass
> - the same system proxies are returned with and without this patch
> - WinHTTP is not loaded unless DefaultProxySelector is used
test/jdk/java/net/ProxySelector/SystemProxies.java line 26:
> 24: /*
> 25: * @test
> 26: * @bug 6912868 8170868 8316433
You may have used this test to ensure that the change didn't cause a regression but I don't think it should be added the `@bug` list for the test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15793#discussion_r1329642122
More information about the build-dev
mailing list