RFR: 8296246: Update Unicode Data Files to Version 15.1.0 [v3]
Naoto Sato
naoto at openjdk.org
Tue Sep 19 18:55:55 UTC 2023
On Tue, 19 Sep 2023 16:18:18 GMT, Joe Wang <joehw at openjdk.org> wrote:
>> Naoto Sato has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Fix GensrcRegex.gmk
>> - Merge branch 'master' into JDK-8296246-Unicode15.1
>> - Update make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - Update make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>> - TR29 final version
>> - .md file update
>> - Final 8/28
>> - Draft 8/11
>> - GenerateExtraProperties tool
>> - initial commit
>
> make/jdk/src/classes/build/tools/generateextraproperties/GenerateExtraProperties.java line 41:
>
>> 39: /**
>> 40: * Parses extra properties files of UCD, and replaces the placeholders in
>> 41: * the given template source file with the generated conditions, then emit
>
> s/emit/emits?
Thanks. Fixed it along with @srl295 's suggestion
> make/modules/java.base/gensrc/GensrcRegex.gmk line 35:
>
>> 33: INDICCONJUNCTBREAKTEMP := $(MODULE_SRC)/share/classes/jdk/internal/util/regex/IndicConjunctBreak.java.template
>> 34: INDICCONJUNCTBREAKPROPS := $(MODULE_SRC)/share/data/unicodedata/DerivedCoreProperties.txt
>> 35: INDICCONJUNCTBREAKPARAMS := InCB=Linker InCB=Extend InCB=Consonant
>
> DerivedCoreProperties.txt is very large. Would it be helpful to reference the section, that is "Derived Property: Indic_Conjunct_Break", in this file or the template?
Added explanation in `IndicConjunctBreak.java.template`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1330570147
PR Review Comment: https://git.openjdk.org/jdk/pull/15728#discussion_r1330570225
More information about the build-dev
mailing list