RFR: 8316433: net.dll should delay load winhttp.dll [v2]

[Julian Waters]

On Tue, 19 Sep 2023 07:02:32 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> WinHTTP functions are only used when an application:
>> - uses DefaultProxySelector to resolve proxies, and
>> - is run with -Djava.net.useSystemProxies=true
>> 
>> In all other cases, loading winhttp.dll is a waste of resources.
>> 
>> Verified that:
>> - existing tier1 and tier2 tests still pass
>> - the same system proxies are returned with and without this patch
>> - WinHTTP is not loaded unless DefaultProxySelector is used
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert test changes

make/modules/java.base/Lib.gmk line 55:

> 53:     LDFLAGS := $(LDFLAGS_JDKLIB) \
> 54:         $(call SET_SHARED_LIBRARY_ORIGIN), \
> 55:     LDFLAGS_windows := -delayload:secur32.dll -delayload:iphlpapi.dll \

Wonder if this could be `LDFLAGS_microsoft_windows` to emphasize the compiler that this applies to

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15793#discussion_r1330945633