RFR: 8315786: [AIX] Build Disk Local Detection Issue with GNU-utils df on AIX [v2]

Erik Joelsson erikj at openjdk.org
Wed Sep 20 12:49:44 UTC 2023


On Wed, 20 Sep 2023 10:21:36 GMT, Deepa Kumari <duke at openjdk.org> wrote:

>> Previously [JDK-8304364](https://github.com/openjdk/jdk/pull/13066/files) , the AIX build process raised complaints about the disk location detection, incorrectly determining that the build wasn't on a local disk. However, a partial fix introduced a new problem, the build process consistently reports that it's on a local disk, even when it's not
>> The core problem here seems to be that Bash treats quoted commands as string literals, and it only evaluates them if you use 'eval' directly.
>>  The  change ensure that Bash correctly evaluates the **DF** variable as a command.
>> 
>> Reported Issue : [JDK-8315786](https://bugs.openjdk.org/browse/JDK-8315786)
>
> Deepa Kumari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove quotes

Looks good. I assume you have verified that this still works.

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15592#pullrequestreview-1635555604


More information about the build-dev mailing list