RFR: 8316433: net.dll should delay load winhttp.dll [v2]

Daniel Jeliński djelinski at openjdk.org
Wed Sep 20 12:52:42 UTC 2023


On Wed, 20 Sep 2023 12:44:05 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> make/modules/java.base/Lib.gmk line 55:
>> 
>>> 53:     LDFLAGS := $(LDFLAGS_JDKLIB) \
>>> 54:         $(call SET_SHARED_LIBRARY_ORIGIN), \
>>> 55:     LDFLAGS_windows := -delayload:secur32.dll -delayload:iphlpapi.dll \
>> 
>> Wonder if this could be `LDFLAGS_microsoft_windows` to emphasize the compiler that this applies to
>
> I wouldn't mind that if you think it's only reasonable to support this with Visual Studio.

it's useful for VS and clang, but not supported by GCC (yet?). Since neither GCC nor Clang is supported now, I'd rather keep it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15793#discussion_r1331581196


More information about the build-dev mailing list