Integrated: 8316532: Native library copying in BuildMicrobenchmark.gmk cause dups on macOS

Erik Joelsson erikj at openjdk.org
Wed Sep 20 20:39:47 UTC 2023


On Tue, 19 Sep 2023 17:59:05 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> After [JDK-8253620](https://bugs.openjdk.org/browse/JDK-8253620), BuildMicrobenchmark.gmk has started printing warnings about overriding targets on macos. This is caused by a CopyFiles using the `FLATTEN` option in combination with debug symbols on macos having the same filename as the dylib itself.
> 
> In this fix, I'm changing the CopyFiles to no longer flatten the file structure. I'm also filtering the list of files to be copied to only include files from the native output `lib` dir. This avoids having any files from the support dir (e.g. dependency *.d files) from being copied into the test image. The resulting native directory in the test-image ends up having all native libraries in it, with debug symbols in their respective *.dSYM sub-directories, as expected.

This pull request has now been integrated.

Changeset: 3461c7b1
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3461c7b16549b2aa456fffad9d6abe7e1bfc7260
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

8316532: Native library copying in BuildMicrobenchmark.gmk cause dups on macOS

Reviewed-by: ihse, redestad

-------------

PR: https://git.openjdk.org/jdk/pull/15824


More information about the build-dev mailing list