RFR: 8316421: libjava should load shell32.dll eagerly [v2]
Daniel Jeliński
djelinski at openjdk.org
Thu Sep 21 07:46:44 UTC 2023
On Wed, 20 Sep 2023 14:42:40 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> src/java.base/windows/native/libjava/java_props_md.c line 214:
>>
>>> 212: HRESULT hr;
>>> 213: WCHAR *tmpPath = NULL;
>>> 214: hr = SHGetKnownFolderPath(&FOLDERID_Profile, KF_FLAG_DONT_VERIFY, NULL, &tmpPath);
>>
>> I'd say inline the variable declaration here as well
>> Suggestion:
>>
>> HRESULT hr = SHGetKnownFolderPath(&FOLDERID_Profile, KF_FLAG_DONT_VERIFY, NULL, &tmpPath);
>
> (And you will have to remove the declaration from the line above)
Done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15789#discussion_r1332620350
More information about the build-dev
mailing list