RFR: 8307160: [REDO] Enable the permissive- flag on the Microsoft Visual C compiler [v2]

[Magnus Ihse Bursie]

On Tue, 8 Aug 2023 19:57:12 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 22 additional commits since the last revision:
>> 
>>  - Mismatched declaration in D3DGlyphCache.cpp
>>  - Fields in awt_TextComponent.cpp
>>  - reinterpret_cast needed in AccessBridgeJavaEntryPoints.cpp
>>  - Qualifiers in awt_PrintDialog.h should be removed
>>  - Likewise for awt_DnDDT.cpp
>>  - awt_ole.h include order issue in awt_DnDDS.cpp
>>  - Revert awt_ole.h
>>  - Earlier fix in awt_ole.h was not complete
>>  - Merge branch 'openjdk:master' into patch-10
>>  - Likewise for awt_Frame.cpp
>>  - ... and 12 more: https://git.openjdk.org/jdk/compare/3ab6ec2a...51230f3d
>
> src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 216:
> 
>> 214:     {
>> 215:         PDATA pData;
>> 216:         JNI_CHECK_PEER_GOTO(canvas, ret);
> 
> Here, and other places: why this scope?

~~I am curious about this, too. What aspect of the code is different from the pedantic compiler perspective?~~

edit: Found the answer further down in the comments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1332748161