RFR: 8316433: net.dll should delay load winhttp.dll [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Sep 21 10:09:40 UTC 2023
On Tue, 19 Sep 2023 07:02:32 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> WinHTTP functions are only used when an application:
>> - uses DefaultProxySelector to resolve proxies, and
>> - is run with -Djava.net.useSystemProxies=true
>>
>> In all other cases, loading winhttp.dll is a waste of resources.
>>
>> Verified that:
>> - existing tier1 and tier2 tests still pass
>> - the same system proxies are returned with and without this patch
>> - WinHTTP is not loaded unless DefaultProxySelector is used
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert test changes
Looks good to me.
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15793#pullrequestreview-1637441771
More information about the build-dev
mailing list