RFR: 8312522: Implementation of Foreign Function & Memory API [v22]

Jorn Vernee jvernee at openjdk.org
Fri Sep 22 15:09:24 UTC 2023


On Fri, 22 Sep 2023 13:39:00 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Avoid eager use of LibFallback in FallbackLinker static block
>
> src/java.base/share/classes/java/lang/foreign/Linker.java line 152:
> 
>> 150:  * <p>
>> 151:  * The following table shows some examples of how C types are modelled in Linux/x64 according to the
>> 152:  * "System V Application Binary Interface - AMD64 Architecture Processor Supplement" (all the examples provided
> 
> I have seen some discussion on this and I agree an authoritative link does not exist (I have searched for it in the past). I guess I'm not super wild about also including "AMD64 Architecture Processor Supplement". E.g. IMHO "System V Application Binary Interface" is more than enough?

Ok, I think I agree, given that we already name x64 as a platform.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15103#discussion_r1334509092


More information about the build-dev mailing list