RFR: JDK-8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc

Joachim Kern jkern at openjdk.org
Tue Apr 2 11:37:59 UTC 2024


On Tue, 2 Apr 2024 11:28:30 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 103:
>> 
>>> 101: #endif
>>> 102: 
>>> 103: #if !defined(LINUX) && !defined(_ALLBSD_SOURCE) && !defined(_AIX)
>> 
>> I believe this whole section can be removed now.
>> 
>> At least I have no idea who this is for. What gcc versions does OpenJDK still support, then, beside these platforms. Also, any gcc platform not on linux or bsd would have hit the #error below at line 132.
>
> linux macos and now Aix use this file.

Who is able to explain if 
`#if defined(LINUX) || defined(_ALLBSD_SOURCE) || defined(_AIX)`
 in this file is equivalent to
`#if 1`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1547692144


More information about the build-dev mailing list