RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v52]

[Magnus Ihse Bursie]

On Fri, 22 Mar 2024 12:26:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert Formatting in awt_Component.cpp
>>  - Revert Formatting in awt_Window.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 779:
> 
>> 777:     }
>> 778: 
>> 779: 
> 
> Suggestion:

To be clear: I recommend deleting this line, since it does not make sense to have two consecutive blank lines here.

> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 1316:
> 
>> 1314:     env->CallVoidMethod(newPaper, setImageableID, ix, iy, iw, ih);
>> 1315: 
>> 1316: 
> 
> Suggestion:

I recommend deleting this line, since it does not make sense to have two consecutive blank lines here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1547831604
PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1547832678