RFR: 8307160: Fix AWT/2D/A11Y to support the permissive- flag on the Microsoft Visual C compiler [v70]

Magnus Ihse Bursie ihse at openjdk.org
Tue Apr 2 15:53:25 UTC 2024


On Mon, 1 Apr 2024 10:33:41 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with four additional commits since the last revision:
>> 
>>  - Labels to empty line in awt_Window.cpp
>>  - Labels to empty line in awt_Window.cpp
>>  - Label to empty line in awt_Window.cpp
>>  - Label to empty line in awt_Window.cpp
>
> Bumping

@TheShermanTanker I tried to help you get this done. I added fixes to a copy of your branch on my personal fork, but then it turned out I could not push them to your branch. :-(

It ended up with me creating a new PR, https://github.com/openjdk/jdk/pull/18584. As a bonus, I think it might be easier to review with a fresh start. This PR has grown quite heavy with lots of comments and commits.

I hope you don't feel like I'm stealing this away from you. You have done a great job, and shown a lot of patience of carrying this all the way here. But I also got the impression that you would appreciate my assistance in getting the last pieces in place so we can integrate this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15096#issuecomment-2032430773


More information about the build-dev mailing list