RFR: JDK-8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]

[Kim Barrett]

On Tue, 2 Apr 2024 11:20:49 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 62:
>> 
>>> 60: #include <errno.h>
>>> 61: 
>>> 62: #if defined(LINUX) || defined(_ALLBSD_SOURCE) || defined(_AIX)
>> 
>> What else is left? Could we just remove this line altogether now?
>
> I cannot answer this question.
> If this line is now obsolete it was also obsolete before including AIX, because AIX didn't use this file beforehand.

There was at one time an attempt at a gcc/Solaris port, but I think it was
never completed, and most vestiges removed. More recently, @TheShermanTanker
has been doing stuff to permit clang/Windows, and clang-based builds use this file.
I'm kind of surprised he hasn't encountered problems and done some cleanup here.

<inttypes.h> (and <cinttypes>) and 64bit integer types are standard C++ now,
so no longer need all this conditionalization. I suggest cleaning that up as a
separate precursor. That would eliminate the two !defined blocks entirely. I
wish the other conditional includes in this block were "where needed" rather
than in globalDefinitions_gcc.hpp, but that's a different mess.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1548225495