RFR: 8311302: Allow for jlinking a custom runtime without packaged modules being present [v23]

[Severin Gehwolf]

On Thu, 21 Mar 2024 15:29:45 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> make/Images.gmk line 145:
>> 
>>> 143:   $(eval $(call SetupJavaCompilation, BUILD_JDK_RUNLINK_CLASSES, \
>>> 144:       COMPILER := buildjdk, \
>>> 145:       DISABLED_WARNINGS := try, \
>> 
>> Why do we get warnings in the java code?
>
> That's not needed anymore. There are some `try` warnings in the `JmodsReader` and `JimageDiffGenerator` classes which used to get compiled with this. It'll probably change again...

No longer there.

>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/runtimelink/JimageDiffGenerator.java line 40:
>> 
>>> 38: public class JimageDiffGenerator {
>>> 39: 
>>> 40:     private static final boolean DEBUG = false;
>> 
>> This seems like left-over debug code. If this should go into product code I suggest you either remove it, or alternatively make it possible to change at runtime, if the debug functionality will be needed.
>
> OK.

Removed in the latest version. The debug static in the build tools class can be enabled with a property.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1551544541
PR Review Comment: https://git.openjdk.org/jdk/pull/14787#discussion_r1551547273