RFR: 8329672: Only call SetupNativeCompilation from SetupJdkNativeCompilation

Thu Apr 4 16:13:33 UTC 2024

This patch will fix the few remaining places where a "raw" call to SetupNativeCompilation was made, instead of going via SetupJdkNativeCompilation. This include repairing the poor old X11Wrapper, which has been broken for some time.

After this we can finally make SetupNativeCompilation an "inner macro" of SetupJdkNativeCompilation, and stop exposing two different ways of compiling native code.

I have also added standard header comments to some places where I have missed it, and corrected an incorrect indentation (all things I found while double-checking all SetupJdkNativeCompilation calls).

-------------

Commit messages:
 - 8329672: Only call SetupNativeCompilation from SetupJdkNativeCompilation

Changes: https://git.openjdk.org/jdk/pull/18631/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18631&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329672
  Stats: 107 lines in 15 files changed: 46 ins; 23 del; 38 mod
  Patch: https://git.openjdk.org/jdk/pull/18631.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18631/head:pull/18631

PR: https://git.openjdk.org/jdk/pull/18631