RFR: 8329672: Only call SetupNativeCompilation from SetupJdkNativeCompilation [v2]

[Magnus Ihse Bursie]

On Thu, 4 Apr 2024 20:50:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This patch will fix the few remaining places where a "raw" call to SetupNativeCompilation was made, instead of going via SetupJdkNativeCompilation. This include repairing the poor old X11Wrapper, which has been broken for some time.
>> 
>> After this we can finally make SetupNativeCompilation an "inner macro" of SetupJdkNativeCompilation, and stop exposing two different ways of compiling native code.
>> 
>> I have also added standard header comments to some places where I have missed it, and corrected an incorrect indentation (all things I found while double-checking all SetupJdkNativeCompilation calls).
>
> Magnus Ihse Bursie has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Update documentation
>  - Do not add LIBCXX for tests
>  - Add ability to disable DEFAULT_VERSIONINFO_RESOURCE

Just to confirm; this PR now passes with byte-by-byte identical builds compared to master.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18631#issuecomment-2038245442