RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]

Hamlin Li mli at openjdk.org
Fri Apr 5 12:17:18 UTC 2024


On Thu, 4 Apr 2024 21:55:54 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - disable unused-function warnings; add log msg
>>  - minor
>
> make/modules/jdk.incubator.vector/Lib.gmk line 44:
> 
>> 42:   $(eval $(call SetupJdkLibrary, BUILD_LIBVECTORMATH, \
>> 43:       NAME := vectormath, \
>> 44:       CFLAGS := $(CFLAGS_JDKLIB) -Wno-error=unused-function, \
> 
> Should the unused-function be passed in using `DISABLE_WARNINGS_*` instead?

Thanks!
Good suggestion, it makes the output clean.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18605#discussion_r1553519958


More information about the build-dev mailing list