RFR: 8328614: hsdis: dlsym can't find decode symbol [v3]
    Magnus Ihse Bursie 
    ihse at openjdk.org
       
    Tue Apr  9 09:17:09 UTC 2024
    
    
  
On Fri, 5 Apr 2024 10:45:24 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider.
>> 
>> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols.
>> Tested with gcc and clang, and llvm and binutils backend.
>> 
>> I didn't find any use of the "DLL_ENTRY", so I removed it.
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use JNIEXPORT
FYI: The 2-reviewer rule only applies to Hotspot (and some other specific parts of the code base), and not generally for JDK fixes. So you had been fine to push with just one reviewer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2044521203
    
    
More information about the build-dev
mailing list