RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]
Hamlin Li
mli at openjdk.org
Tue Apr 9 15:36:13 UTC 2024
On Fri, 5 Apr 2024 12:17:17 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Hi,
>> Can you help to review the patch?
>> This pr is based on previous work and discussion in [pr 16234](https://github.com/openjdk/jdk/pull/16234), [pr 18294](https://github.com/openjdk/jdk/pull/18294).
>>
>> Compared with previous prs, the major change in this pr is to integrate the source of sleef (for the steps, please check `src/jdk.incubator.vector/linux/native/libvectormath/README`), rather than depends on external sleef things (header or lib) at build or run time.
>> Besides of this change, also modify the previous changes accordingly, e.g. remove some uncessary files or changes especially in make dir of jdk.
>>
>> Besides of the code changes, one important task is to handle the legal process.
>>
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with two additional commits since the last revision:
>
> - disable unused-function warnings; add log msg
> - minor
Just a quick update, this pr introduces some performance regression compared with previous version (https://github.com/openjdk/jdk/pull/18294) for some math functions (e.g. Double256Vector.COS), and no regression for some others (e.g. Double256Vector.ACOS).
I'm investigating.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18605#issuecomment-2045495626
More information about the build-dev
mailing list