RFR: JDK-8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]

Joachim Kern jkern at openjdk.org
Wed Apr 10 09:20:12 UTC 2024


On Tue, 9 Apr 2024 16:59:39 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Hi Thomas, `maxDisclaimSize` is of type `unsigned int`; therefore I get the following warning:
>> 
>> os/aix/os_aix.cpp:314:42: error: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat]
>>                          RANGEFMTARGS(p, maxDisclaimSize),
>>                                          ^~~~~~~~~~~~~~~
>> 
>> Should I keep the casts, or change the type of `maxDisclaimSize, numFullDisclaimsNeeded, lastDisclaimSize` to `const unsigned long`?
>
> I would change them to size_t. Thanks for doing this.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1559121239


More information about the build-dev mailing list