RFR: JDK-8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]
Martin Doerr
mdoerr at openjdk.org
Wed Apr 10 13:49:12 UTC 2024
On Wed, 10 Apr 2024 13:35:39 GMT, Julian Waters <jwaters at openjdk.org> wrote:
>> Yes I believe. I will remove the `#pragma alloca` everywhere, I will remove the `#include <alloca.h>` everywhere and I will add `-Dalloca=__builtin_alloca` to the compile commands. If it works I will update the PR.
>
> In my humble opinion the inclusion of alloca.h was slightly cleaner, but I guess it doesn't matter. Out of curiosity, why do you guys prefer not including it?
When only looking at AIX code, I think the inclusion of alloca.h was cleaner. Agreed. The new code makes AIX behave like other platforms and avoids the AIX specific part in shared code.
I could live with either version.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1559470659
More information about the build-dev
mailing list