RFR: 8326947: Minimize MakeBase.gmk [v2]

Magnus Ihse Bursie ihse at openjdk.org
Thu Apr 11 11:14:57 UTC 2024


> This is part of a general "spring cleaning" of the build system, addressing old code that has bit-rotted, been subject to lava flow, or just had bad or smelly code that we've never gotten around to fix.
> 
> This particular patch tries to make MakeBase truly minimal; only including the core parts of the build system that all makefiles will need. This is now limited to essential functionality for named parameter functions, variable dependency, tool execution, logging and fixpath functionality. MakeBase still includes Utils.gmk and FileUtils.gmk, and thus "provides" this functionality as well. Separating these out as well will be the subject of a future patch.

Magnus Ihse Bursie has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:

 - Merge branch 'master' into minimize-makebase
 - Whitespace fix
 - MakeBase.gmk should not include MakeIO.gmk anymore
 - MakeBase.gmk should not include CopyFiles.gmk anymore
 - Reorder BaseUtils.gmk to make more sense
 - Move some more functionality to BaseUtils.gmk
 - Create BaseUtils.gmk with the most basic stuff
 - Move all file stuff from Utils.gmk to FileUtils.gmk
 - Document the purpose of MakeBase
 - Move SOURCE_REVISION_TRACKER to where it is used.
   
   This unfortunately creates a duplication, but there is no suitable place to put this information, and it does not belong in MakeBase.
 - ... and 4 more: https://git.openjdk.org/jdk/compare/9acce7a6...36bb38f0

-------------

Changes: https://git.openjdk.org/jdk/pull/18041/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18041&range=01
  Stats: 1099 lines in 43 files changed: 607 ins; 480 del; 12 mod
  Patch: https://git.openjdk.org/jdk/pull/18041.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18041/head:pull/18041

PR: https://git.openjdk.org/jdk/pull/18041


More information about the build-dev mailing list