RFR: 8326947: Minimize MakeBase.gmk [v6]

Erik Joelsson erikj at openjdk.org
Thu Apr 11 13:02:43 UTC 2024


On Thu, 11 Apr 2024 12:48:01 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> This is part of a general "spring cleaning" of the build system, addressing old code that has bit-rotted, been subject to lava flow, or just had bad or smelly code that we've never gotten around to fix.
>> 
>> This particular patch tries to make MakeBase truly minimal; only including the core parts of the build system that all makefiles will need. This is now limited to essential functionality for named parameter functions, variable dependency, tool execution, logging and fixpath functionality. MakeBase still includes Utils.gmk and FileUtils.gmk, and thus "provides" this functionality as well. Separating these out as well will be the subject of a future patch.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix dependency problem from inlining BaseUtils

Looks good now.

-------------

Marked as reviewed by erikj (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18041#pullrequestreview-1994127692


More information about the build-dev mailing list