RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v55]

[Jonathan Gibbons]

On Tue, 9 Apr 2024 08:53:10 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

>> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add support for JDK-8329296: Update Elements for '///' documentation comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java line 443:
> 
>> 441:     @DefinedBy(Api.LANGUAGE_MODEL)
>> 442:     public CommentKind getDocCommentKind(Element e) {
>> 443:         return  getDocCommentItem(e, ((docCommentTable, tree) -> docCommentTable.getCommentKind(tree)));
> 
> Nit:
> Suggestion:
> 
>         return getDocCommentItem(e, ((docCommentTable, tree) -> docCommentTable.getCommentKind(tree)));

Fixed

> src/jdk.compiler/share/classes/com/sun/tools/javac/model/JavacElements.java line 443:
> 
>> 441:     @DefinedBy(Api.LANGUAGE_MODEL)
>> 442:     public CommentKind getDocCommentKind(Element e) {
>> 443:         return  getDocCommentItem(e, ((docCommentTable, tree) -> docCommentTable.getCommentKind(tree)));
> 
> Again:
> Suggestion:
> 
>         return getDocCommentItem(e, ((docCommentTable, tree) -> docCommentTable.getCommentKind(tree)));

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1561382358
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1561382835