RFR: 8329704: Implement framework for proper handling of JDK_LIBS [v8]
Julian Waters
jwaters at openjdk.org
Mon Apr 15 04:22:53 UTC 2024
On Wed, 10 Apr 2024 21:10:27 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> This is the pinnacle of the recent stream of refactorings in the build system. This patch introduces a more abstract concept of "JDK_LIBS", where only the library name (e.g. "java" or "java.desktop:jawt") is specified, and the build system turns this into suitable linker flags: `-ljawt -L<correct path>` or `jawt.lib -libpath:<correct path>`, depending on linker. It will also automatically create proper dependencies.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix missing lib prefix
make/common/JdkNativeCompilation.gmk line 212:
> 210:
> 211: ifneq ($(STATIC_LIBS), true)
> 212: ifeq ($$(call isTargetOs, windows), true)
I should've looked through this more carefully. The selection on whether to use -L and -libpath: should've been based on the compiler, not the target OS
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18649#discussion_r1565162835
More information about the build-dev
mailing list