RFR: 8329257: AIX: Switch HOTSPOT_TOOLCHAIN_TYPE from xlc to gcc [v3]
Julian Waters
jwaters at openjdk.org
Tue Apr 16 09:55:02 UTC 2024
On Tue, 16 Apr 2024 09:15:19 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> That was kind of where the discussion started, and which Kim did not like. If I read him correctly, his suggestion was instead to place:
>>
>> #if defined(_AIX)
>> #include <alloca.h>
>> #endif
>>
>> in the files where `alloca` is needed on AIX.
>
> (If some of these files happen to be files which are not compiled on Windows, I assume it will not hurt to drop the ifdef guard, but then again, it can certainly be kept as well for consistency.)
Windows does use this file, in the unofficial Windows/gcc Port. That said, I am fairly sure the Windows distribution of gcc does recognise alloca.h. It would be a little strange to unconditionally include this if only AIX needs it, though
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1567076923
More information about the build-dev
mailing list