RFR: 8330107: Separate out "awt" libraries from Awt2dLibraries.gmk [v3]

Phil Race prr at openjdk.org
Tue Apr 16 18:09:00 UTC 2024


On Tue, 16 Apr 2024 10:03:27 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> The file to build most of the java.desktop native libraries, Awt2dLibraries.gmk, is large and unstructured, making it hard to navigate.
>> 
>> I want to split it into two parts, one for the AWT libraries, and one for the 2D libraries. I also used this opportunity to change the order to be more logical (e.g. grouping "image" libraries and "font" libraries in 2D).
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Make the split based on the name "awt" instead, and document the reason
>  - Rename 2dLibraries.gmk to ClientLibraries.gmk

I still find this artificial, arbitrary, inconsistent, and even wrong.
The name "awt" in a library isn't a good way to divide it, but I don't have an alternative proposal
because there is no good way to divide it.
And I just don't agree with the premise. Or at least it is far outweighed by everything else.
I see it just sowing confusion and having to change 2 files etc.
So I don't support this change in any variation.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18743#issuecomment-2059664922


More information about the build-dev mailing list