RFR: 8330755: ProblemList files have entries referring to non-existent tests

Doug Simon dnsimon at openjdk.org
Sun Apr 21 22:13:39 UTC 2024


This PR adds a check for the format of ProblemList files and ensures they only have entries referring to existing tests.

The cleanups in the second commit of this PR were done based on the output of `CheckProblemLists`:

> make test TEST=build/problemLists/CheckProblemLists.java
...
STDOUT:
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-Virtual.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-Xcomp.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-generational-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jaxp/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Xcomp.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-generational-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-zgc.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/langtools/ProblemList.txt
Checking /Users/dnsimon/dev/jdk-jdk/open/test/lib-test/ProblemList.txt
Checked 13 problem list files
Test roots:
  /Users/dnsimon/dev/jdk-jdk/open/test/jdk
  /Users/dnsimon/dev/jdk-jdk/open/test/lib-test
  /Users/dnsimon/dev/jdk-jdk/open/test/failure_handler/test
  /Users/dnsimon/dev/jdk-jdk/open/test/jaxp
  /Users/dnsimon/dev/jdk-jdk/open/test/langtools
  /Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg
Following errors found:
/Users/dnsimon/dev/jdk-jdk/open/test/hotspot/jtreg/ProblemList.txt:174: vmTestbase/gc/lock/jni/jnilock002/TestDescription.java does not exist under any test root
vmTestbase/gc/lock/jni/jnilock002/TestDescription.java 8192647 generic-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt:77: TestAndIssue[test=java/util/Properties/StoreReproducibilityTest.java, issueId=0000000] duplicates /Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList-Virtual.txt:76
java/util/Properties/StoreReproducibilityTest.java 0000000 generic-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:516: java/lang/management/MemoryMXBean/PendingAllGC.sh does not exist under any test root
java/lang/management/MemoryMXBean/PendingAllGC.sh               8158837 generic-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:667: javax/swing/JFileChooser/6798062/bug6798062.java does not exist under any test root
javax/swing/JFileChooser/6798062/bug6798062.java 8146446 windows-all

/Users/dnsimon/dev/jdk-jdk/open/test/jdk/ProblemList.txt:775: javax/swing/JTabbedPane/4666224/bug4666224.java does not exist under any test root
javax/swing/JTabbedPane/4666224/bug4666224.java 8144124  macosx-all

STDERR:
java.lang.AssertionError: 5 errors found while checking 13 problem list files
	at CheckProblemLists.main(CheckProblemLists.java:96)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:333)
	at java.base/java.lang.Thread.run(Thread.java:1575)

-------------

Commit messages:
 - removed problem list entries referring to non-existent tests
 - added CheckProblemLists

Changes: https://git.openjdk.org/jdk/pull/18879/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18879&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8330755
  Stats: 217 lines in 4 files changed: 211 ins; 6 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/18879.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18879/head:pull/18879

PR: https://git.openjdk.org/jdk/pull/18879


More information about the build-dev mailing list